Support to prompt_toolkit 3.0 on meshcli#160
Open
tot0rokr wants to merge 1 commit intoSilvairGit:masterfrom
Open
Support to prompt_toolkit 3.0 on meshcli#160tot0rokr wants to merge 1 commit intoSilvairGit:masterfrom
tot0rokr wants to merge 1 commit intoSilvairGit:masterfrom
Conversation
tot0rokr
force-pushed
the
upgrade_prompt_toolkit_30
branch
from
30dae89 to
42e9e18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I used prompt_toolkit v2.0.x, event_loop happens exceptions. I have solved this problem using upgrading to prompt_toolkit v3.0.x, which uses the asyncio event loop natively, rather then using its own implementations of event loops. But I had to change some breaking changes.